refactor(etabs): adds singleton converter cache for material and section relationships #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#511) * This is a workaround for Revit's order of operations when initializing * Fix event listening
clairekuang
changed the base branch from
dev
to
bjorn/cnx-880-add-sections-and-materials-as-proxies
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## bjorn/cnx-880-add-sections-and-materials-as-proxies #514 +/- ##
=======================================================================================
- Coverage 15.05% 14.74% -0.32%
=======================================================================================
Files 239 239
Lines 4703 4674 -29
Branches 578 576 -2
=======================================================================================
- Hits 708 689 -19
+ Misses 3964 3954 -10
Partials 31 31 ☔ View full report in Codecov by Sentry. |
bjoernsteinhagen
approved these changes
Jan 22, 2025
…nt Subscription (#512) * This is a workaround for Revit's order of operations when initializing * Fix event listening * Only allow methods on classes as opposed to anonymous lambdas * formatting * fix tests * weakreference found should remove subscription
|
@clairekuang sample commit with the refactor here. Looking good! 
|
|
Ok to merge then! |
bjoernsteinhagen
merged commit e90423a
into
bjorn/cnx-880-add-sections-and-materials-as-proxies
5 checks passed
bjoernsteinhagen
added a commit
that referenced
this pull request
Jan 22, 2025
* HostAppVersion v21 and v22 following SDK updates * Working POC for material and section proxies * Refactoring section unpacking Refactoring in accordance with PropertiesExtractor example * Material unpackers * Notes and documentation * More explanations * materialId - Interim solution for viewer filtering is appending the materialId to assignments for each object - For FRAME this was easy - For SHELL not so easy. No GetMaterial method avaiable given a AreaObj sectionName. Implemented lightweight materialCache based on cDatabaseTable. Marked as temporary based on previous discussions * Explicit dictionary entries * Repeated property strings as consts - Fair point for repeated strings in the CsiMaterialPropertyExtractor.cs - Even more reason to include this across all repeated strings. Categories of properties screaming out for this. Added additionally * PR review comments - Dictionary lookups for material and section proxies - Only create proxies for assigned sections and materials (not pretty) * refactor(etabs): adds singleton converter cache for material and section relationships (#514) * This is a workaround for Revit's order of operations when initializing (#511) * This is a workaround for Revit's order of operations when initializing * Fix event listening * adds a singleton cache for material and section relationships to csishared * updating extraction results and simplifying classes * Only allow methods on classes as opposed to anonymous lambdas for Event Subscription (#512) * This is a workaround for Revit's order of operations when initializing * Fix event listening * Only allow methods on classes as opposed to anonymous lambdas * formatting * fix tests * weakreference found should remove subscription * doument model store fix (#516) * testing commit --------- Co-authored-by: Adam Hathcock <[email protected]> Co-authored-by: Björn <[email protected]> * resolving conflicts, testing and small tweaks - merged dev into branch - added "type" parameter to group proxies for sections in order to distinguish between frame sections and shell sections --------- Co-authored-by: Claire Kuang <[email protected]> Co-authored-by: Adam Hathcock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the current material/section proxy logic to use a singleton cache in the converter which will store object <> section <> material relationships to be accessed in the connector