Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Event Aggregator with Autocad/Civil #517

Merged
merged 7 commits into from
Jan 28, 2025
Merged

Conversation

adamhathcock
Copy link
Member

No description provided.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.86%. Comparing base (81c3c42) to head (85d64ab).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #517   +/-   ##
=======================================
  Coverage   15.86%   15.86%           
=======================================
  Files         238      238           
  Lines        4720     4720           
  Branches      578      578           
=======================================
  Hits          749      749           
  Misses       3941     3941           
  Partials       30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamhathcock adamhathcock marked this pull request as ready for review January 24, 2025 15:35
@adamhathcock adamhathcock enabled auto-merge (squash) January 28, 2025 08:14
@clairekuang
Copy link
Member

clairekuang commented Jan 28, 2025

Lightly tested autocad and civil doc switch, doc creation, doc delete, object change events - seems to be working well.
I noticed a lot of exceptions on cancellationToken, thrown from PriorityScheduler in the serialiser v2: is this expected?
{886003AF-2C64-4412-BB01-FA2731E83796}

@adamhathcock adamhathcock merged commit 79a6062 into dev Jan 28, 2025
5 checks passed
@adamhathcock adamhathcock deleted the autocad-event-aggregator branch January 28, 2025 10:12
@adamhathcock
Copy link
Member Author

Lightly tested autocad and civil doc switch, doc creation, doc delete, object change events - seems to be working well. I noticed a lot of exceptions on cancellationToken, thrown from PriorityScheduler in the serialiser v2: is this expected? {886003AF-2C64-4412-BB01-FA2731E83796}

Cancellation fixes are coming....this PR doesn't attempt to make it better for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants