-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Event Aggregator with Navisworks #523
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #523 +/- ##
=======================================
Coverage 15.86% 15.86%
=======================================
Files 238 238
Lines 4720 4720
Branches 578 578
=======================================
Hits 749 749
Misses 3941 3941
Partials 30 30 ☔ View full report in Codecov by Sentry. |
Looks legit but I'll test runtime. Not introduced by this PR but thinking harder about something else about repeated one time binding on send. This is what I was going to test again as mentioned: https://discord.com/channels/726756379083145269/751053204103495711/1332369121203196014 // In NavisworksDocumentEvents.cs
_eventAggregator.GetEvent<IdleEvent>().OneTimeSubscribe(
nameof(NavisworksDocumentEvents),
ProcessModelStateChangeAsync
); Might want to verify the cleanup behavior with one-time subscriptions if state changes during processing. Maybe nothing. And not new. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully tested for non-regressions (including the comment mentioning other issue)
No description provided.