Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Event Aggregator with Navisworks #523

Merged
merged 6 commits into from
Jan 28, 2025
Merged

Use Event Aggregator with Navisworks #523

merged 6 commits into from
Jan 28, 2025

Conversation

adamhathcock
Copy link
Member

No description provided.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.86%. Comparing base (67c7ddb) to head (d9e3de2).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #523   +/-   ##
=======================================
  Coverage   15.86%   15.86%           
=======================================
  Files         238      238           
  Lines        4720     4720           
  Branches      578      578           
=======================================
  Hits          749      749           
  Misses       3941     3941           
  Partials       30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsdbroughton
Copy link
Contributor

Looks legit but I'll test runtime.

Not introduced by this PR but thinking harder about something else about repeated one time binding on send. This is what I was going to test again as mentioned: https://discord.com/channels/726756379083145269/751053204103495711/1332369121203196014

// In NavisworksDocumentEvents.cs
_eventAggregator.GetEvent<IdleEvent>().OneTimeSubscribe(
    nameof(NavisworksDocumentEvents), 
    ProcessModelStateChangeAsync
);

Might want to verify the cleanup behavior with one-time subscriptions if state changes during processing.

Maybe nothing. And not new.

Copy link
Contributor

@jsdbroughton jsdbroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully tested for non-regressions (including the comment mentioning other issue)

@adamhathcock adamhathcock marked this pull request as ready for review January 28, 2025 15:17
@adamhathcock adamhathcock enabled auto-merge (squash) January 28, 2025 15:18
@adamhathcock adamhathcock merged commit 9e18134 into dev Jan 28, 2025
5 checks passed
@adamhathcock adamhathcock deleted the navisworks-ea branch January 28, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants