bjorn/cnx-1112-get-user-facing-names-of-properties

[bjoernsteinhagen]

Description & motivation

• Linked to CNX-1112 : property keys should mirror UI names (not api representation).

Changes:

• Changed frame properties, shell properties, material proxies and section proxies to all use UI names
• Add units to all attributes where applicable. This was done only for distance related units (mm, mm², mm³) etc. More complicated units related to force, stress, temperature etc. not part of the scope of this ticket. This will be dealt with in CNX-1097

Screenshots:

Frame Section Properties

Shell Section Properties

Section Proxies Properties

Material Proxies Properties

Checklist:

• My pull request follows the guidelines in the Contributing guide?
• My pull request does not duplicate any other open Pull Requests for the same update/change?
• My commits are related to the pull request and do not amend unrelated code or documentation.
• My code follows a similar style to existing code.
• I have added appropriate tests.
• I have updated or added relevant documentation.

[linear]

CNX-1112 Get user facing names of properties

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.35%. Comparing base (4d7225f) to head (7f4e971).
Report is 1 commits behind head on dev.

Additional details and impacted files

@@           Coverage Diff           @@
##              dev     #526   +/-   ##
=======================================
  Coverage   17.35%   17.35%           
=======================================
  Files         239      239           
  Lines        4805     4805           
  Branches      579      579           
=======================================
  Hits          834      834           
  Misses       3941     3941           
  Partials       30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[clairekuang]

we don't have property naming standards atm, but the standing rule is using the api prop name in camelcase with no spaces. would prefer to keep this convention for now, but not critical

[bjoernsteinhagen]

cc'ing @bimgeek. I think we'll need to formalize this for all (either camel or user facing).

[bimgeek]

Since we are using user-facing property names in Revit, I understand that this is our target in other connectors for data extraction workflows as it's easier to navigate. However, @clairekuang knows better.