bjorn/cnx-1111-switching-documents-does-not-invalidate-active-connector

[bjoernsteinhagen]

Description & motivation

• Related to CNX-1111.
• When user opens a new Etabs model without closing the plugin, the model cards associated with the previous model remain visible.

Changes:

• Polling in the CsiDocumentModelStore to detect changes in the ModelFilename. A change indicates a new model at which point we reload.

Screenshots:

Before Changes

See video in CNX-1111.

After Changes

Reloading.Plugin.mp4

Checklist:

• My pull request follows the guidelines in the Contributing guide?
• My pull request does not duplicate any other open Pull Requests for the same update/change?
• My commits are related to the pull request and do not amend unrelated code or documentation.
• My code follows a similar style to existing code.
• I have added appropriate tests.
• I have updated or added relevant documentation.

[linear]

CNX-1111 Switching documents does not invalidate active connector session (rename as you like)

[bjoernsteinhagen]

@oguzhankoral we're now polling in two places (😢):

• SpeckleFormBase.cs - to check when and if a user opens a new model
• CsiSharedSelectionBinding.cs - to check when a Selection changes.

Thoughts?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.86%. Comparing base (9e18134) to head (6ac5191).
Report is 1 commits behind head on dev.

Additional details and impacted files

@@           Coverage Diff           @@
##              dev     #528   +/-   ##
=======================================
  Coverage   15.86%   15.86%           
=======================================
  Files         238      238           
  Lines        4720     4720           
  Branches      578      578           
=======================================
  Hits          749      749           
  Misses       3941     3941           
  Partials       30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[oguzhankoral]

I would handle doc switch on DocumentStore and call LoadState, it should ideally trigger refreshing the state