Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DUI3-426 PR moved from https://github.com/specklesystems/speckle-sharp/pull/3545 #7

Merged
merged 20 commits into from
Jul 15, 2024

Conversation

KatKatKateryna
Copy link
Member

Description & motivation

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

Sorry, something went wrong.

@adamhathcock
Copy link
Member

let me know if you need help

@KatKatKateryna
Copy link
Member Author

Blocked again by repeated generation on ContextStack mid-operation. This is overwriting the settings applied to ContextStack

@KatKatKateryna KatKatKateryna marked this pull request as ready for review July 11, 2024 03:34
@adamhathcock
Copy link
Member

run format please

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 5.74%. Comparing base (c241028) to head (59160b9).
Report is 10 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff            @@
##             dev      #7      +/-   ##
========================================
+ Coverage   0.00%   5.74%   +5.74%     
========================================
  Files        161     168       +7     
  Lines       3146    3448     +302     
  Branches     340     423      +83     
========================================
+ Hits           0     198     +198     
- Misses      3144    3247     +103     
- Partials       2       3       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlanRynne AlanRynne changed the title PR moved from https://github.com/specklesystems/speckle-sharp/pull/3545 DUI3-426 PR moved from https://github.com/specklesystems/speckle-sharp/pull/3545 Jul 12, 2024
@KatKatKateryna KatKatKateryna merged commit abe5a07 into dev Jul 15, 2024
6 checks passed
@KatKatKateryna KatKatKateryna deleted the AGIS-customCRS_offsets_rotation branch July 15, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants