-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(rhino): CNX-19 adds render materials to objects and layers #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #74 +/- ##
=====================================
Coverage 8.00% 8.00%
=====================================
Files 228 228
Lines 4371 4371
Branches 489 489
=====================================
Hits 350 350
Misses 4011 4011
Partials 10 10 ☔ View full report in Codecov by Sentry. |
didimitrie
approved these changes
Jul 25, 2024
oguzhankoral
approved these changes
Jul 25, 2024
… object builder co-authored with @oguzhankoral
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors render materials to be sent as a
List<RenderMaterialProxy>
on the root commit, which contains the object ids of objects using the render material. Also adds render materials to layers.sample commit: https://app.speckle.systems/projects/93200a735d/models/cbacd3eaeb
Notes:
RhinoHostObjectBuilder
on receive is looking especially ugly.Gem
, are not translated well into ourRenderMaterial
class, especially with a transparency set to 1.