Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rhino): CNX-19 adds render materials to objects and layers #74

Merged
merged 10 commits into from
Jul 25, 2024

Conversation

clairekuang
Copy link
Member

@clairekuang clairekuang commented Jul 25, 2024

Refactors render materials to be sent as a List<RenderMaterialProxy> on the root commit, which contains the object ids of objects using the render material. Also adds render materials to layers.

sample commit: https://app.speckle.systems/projects/93200a735d/models/cbacd3eaeb

Notes:

  1. might want to refactor send and recieve so that layers are processed separately from objects. Currently, creating layers in the object iteration means higher complexity in assigning / creating render materials as well. RhinoHostObjectBuilder on receive is looking especially ugly.
  2. the built in pbr materials in rhino, eg Gem, are not translated well into our RenderMaterial class, especially with a transparency set to 1.

image

Copy link

linear bot commented Jul 25, 2024

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 8.00%. Comparing base (c2a53f6) to head (7b199c2).

Additional details and impacted files
@@          Coverage Diff          @@
##             dev     #74   +/-   ##
=====================================
  Coverage   8.00%   8.00%           
=====================================
  Files        228     228           
  Lines       4371    4371           
  Branches     489     489           
=====================================
  Hits         350     350           
  Misses      4011    4011           
  Partials      10      10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@didimitrie didimitrie enabled auto-merge (squash) July 25, 2024 16:10
@didimitrie didimitrie merged commit 4ed8175 into dev Jul 25, 2024
4 checks passed
@didimitrie didimitrie deleted the CNX-19 branch July 25, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants