Enforced msbuild warnings (#166)

* Enforced msbuild warnings

* removed inline suppression

* fix

Directory.Build.props

@@ -51,13 +51,13 @@
       <!-- Globalization rules -->
       CA1303;CA1304;CA1305;CA1307;CA1308;CA1309;CA1310;CA1311;
       <!-- Logging -->
-      CA1848;CA2254;CA1727;
+      CA1848;CA1727;
       <!-- Others we don't want -->
       CA1815;CA1725;
       <!-- Naming things is hard enough -->
-      CA1710;CA1711;CA1724;CA1716;CA1720;CA1724;
+      CA1710;CA1711;CA1720;CA1724;
       <!-- Aspirational -->
-      CA1502;
+      CA1502;CA1716;NETSDK1206;
       $(NoWarn)
     </NoWarn>
   </PropertyGroup>

build/Program.cs

@@ -66,7 +66,7 @@ void RemoveDirectory(string d)
   DependsOn(RESTORE),
   async () =>
   {
-    await RunAsync("dotnet", $"build Speckle.Sdk.sln -c Release --no-restore").ConfigureAwait(false);
+    await RunAsync("dotnet", $"build Speckle.Sdk.sln -c Release --no-restore -warnaserror").ConfigureAwait(false);
   }
 );
 
@@ -81,7 +81,6 @@ await RunAsync(
         $"test {file} -c Release --no-build --no-restore --verbosity=normal  /p:AltCover=true  /p:AltCoverAttributeFilter=ExcludeFromCodeCoverage /p:AltCoverVerbosity=Warning"
       )
       .ConfigureAwait(false);
-    ;
   }
 );
 
@@ -91,15 +90,13 @@ await RunAsync(
   async () =>
   {
     await RunAsync("docker", "compose -f docker-compose.yml up --wait").ConfigureAwait(false);
-    ;
     foreach (var test in Glob.Files(".", "**/*.Tests.Integration.csproj"))
     {
       await RunAsync(
           "dotnet",
           $"test {test} -c Release --no-build --no-restore --verbosity=normal  /p:AltCover=true  /p:AltCoverAttributeFilter=ExcludeFromCodeCoverage"
         )
         .ConfigureAwait(false);
-      ;
     }
     await RunAsync("docker", "compose down").ConfigureAwait(false);
   }

global.json

@@ -1,6 +1,6 @@
 {
   "sdk": {
-    "version": "8.0.100",
+    "version": "8.0.400",
     "rollForward": "latestMinor"
   }
 }

src/Speckle.Sdk/Speckle.Sdk.csproj

@@ -3,7 +3,6 @@
 
   <PropertyGroup Label="Compiler Properties">
     <TargetFrameworks>netstandard2.0;net8.0</TargetFrameworks>
-    <PolySharpExcludeGeneratedTypes>System.Runtime.CompilerServices.RequiresLocationAttribute</PolySharpExcludeGeneratedTypes>
     <Configurations>Debug;Release;Local</Configurations>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
   </PropertyGroup>
@@ -29,7 +28,7 @@
   <ItemGroup Label="Package References">    
     <PackageReference Include="GraphQL.Client"/>
     <PackageReference Include="Microsoft.CSharp" />
-    <PackageReference Include="Microsoft.Data.Sqlite" />
+    <PackageReference Include="Microsoft.Data.Sqlite"/>
     <PackageReference Include="Speckle.DoubleNumerics" />
     <PackageReference Include="Speckle.Newtonsoft.Json" />
   </ItemGroup>