Don't use Serilog global static logger in v3 (#96)

* Don't use Serilog global static logger in v3 * make logger be internal only
specklesystems · Sep 2, 2024 · 7883cd9 · 7883cd9
1 parent b7be9b6
commit 7883cd9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Speckle.Sdk.Logging/LogBuilder.cs b/src/Speckle.Sdk.Logging/LogBuilder.cs
@@ -69,7 +69,7 @@ public static class LogBuilder
       serilogLogConfiguration = InitializeOtelLogging(serilogLogConfiguration, speckleLogging.Otel, resourceBuilder);
     }
     var logger = serilogLogConfiguration.CreateLogger();
-    Log.Logger = logger;
+    SpeckleLog.SpeckleLogger = logger;
 
     logger
       .ForContext("hostApplication", applicationAndVersion)

diff --git a/src/Speckle.Sdk.Logging/SpeckleLog.cs b/src/Speckle.Sdk.Logging/SpeckleLog.cs
@@ -1,12 +1,12 @@
-using Serilog;
 using Serilog.Core;
 
 namespace Speckle.Sdk.Logging;
 
 public static class SpeckleLog
 {
-  public static ISpeckleLogger Logger => new SpeckleLogger(Serilog.Log.Logger);
+  internal static Serilog.ILogger SpeckleLogger { get; set; } = Serilog.Core.Logger.None;
+  public static ISpeckleLogger Logger => new SpeckleLogger(SpeckleLogger);
 
   public static ISpeckleLogger Create(string name) =>
-    new SpeckleLogger(Log.Logger.ForContext(Constants.SourceContextPropertyName, name));
+    new SpeckleLogger(SpeckleLogger.ForContext(Constants.SourceContextPropertyName, name));
 }