Detach Levels (#99)

specklesystems · Sep 3, 2024 · b918002 · b918002
1 parent 77a40a3
commit b918002
Show file tree

Hide file tree

Showing 21 changed files with 43 additions and 0 deletions.
diff --git a/src/Speckle.Objects/BuiltElements/Area.cs b/src/Speckle.Objects/BuiltElements/Area.cs
@@ -23,6 +23,8 @@ public Area(string name, string number, Level level, [SchemaMainParam] Point cen
 
   public string name { get; set; }
   public string number { get; set; }
+
+  [DetachProperty]
   public Level level { get; set; }
   public Point center { get; set; }
   public List<ICurve> voids { get; set; } = new();

diff --git a/src/Speckle.Objects/BuiltElements/Revit/BuildingPad.cs b/src/Speckle.Objects/BuiltElements/Revit/BuildingPad.cs
@@ -12,6 +12,7 @@ public class BuildingPad : Base, IDisplayValue<List<Mesh>>
 
   public string type { get; set; }
 
+  [DetachProperty]
   public Level level { get; set; }
 
   public Base parameters { get; set; }

diff --git a/src/Speckle.Objects/BuiltElements/Revit/Curve/ModelCurves.cs b/src/Speckle.Objects/BuiltElements/Revit/Curve/ModelCurves.cs
@@ -61,6 +61,8 @@ public RoomBoundaryLine([SchemaMainParam] ICurve baseCurve, List<Parameter>? par
   public ICurve baseCurve { get; set; }
   public Base? parameters { get; set; }
   public string elementId { get; set; }
+
+  [DetachProperty]
   public Level level { get; set; }
   public string units { get; set; }
 }

diff --git a/src/Speckle.Objects/BuiltElements/Revit/FamilyInstance.cs b/src/Speckle.Objects/BuiltElements/Revit/FamilyInstance.cs
@@ -37,6 +37,8 @@ public FamilyInstance(
   public string family { get; set; }
   public string type { get; set; }
   public string category { get; set; }
+
+  [DetachProperty]
   public Level level { get; set; }
   public double rotation { get; set; }
   public bool facingFlipped { get; set; }

diff --git a/src/Speckle.Objects/BuiltElements/Revit/RevitBrace.cs b/src/Speckle.Objects/BuiltElements/Revit/RevitBrace.cs
@@ -33,6 +33,8 @@ public RevitBrace(
   public string type { get; set; }
   public Base? parameters { get; set; }
   public string? elementId { get; set; }
+
+  [DetachProperty]
   public Level? level { get; set; }
 
   #region Schema Info Constructor

diff --git a/src/Speckle.Objects/BuiltElements/Revit/RevitCableTray.cs b/src/Speckle.Objects/BuiltElements/Revit/RevitCableTray.cs
@@ -8,6 +8,8 @@ public class RevitCableTray : CableTray, IHasMEPConnectors
 {
   public string family { get; set; }
   public string type { get; set; }
+
+  [DetachProperty]
   public Level level { get; set; }
   public Base parameters { get; set; }
   public string elementId { get; set; }

diff --git a/src/Speckle.Objects/BuiltElements/Revit/RevitCeiling.cs b/src/Speckle.Objects/BuiltElements/Revit/RevitCeiling.cs
@@ -61,6 +61,8 @@ public RevitCeiling(
 
   public string family { get; set; }
   public string type { get; set; }
+
+  [DetachProperty]
   public Level level { get; set; }
   public double slope { get; set; }
   public Line? slopeDirection { get; set; }

diff --git a/src/Speckle.Objects/BuiltElements/Revit/RevitColumn.cs b/src/Speckle.Objects/BuiltElements/Revit/RevitColumn.cs
@@ -42,6 +42,7 @@ public RevitColumn(
     this.parameters = parameters?.ToBase();
   }
 
+  [DetachProperty]
   public Level? topLevel { get; set; }
   public double baseOffset { get; set; }
   public double topOffset { get; set; }

diff --git a/src/Speckle.Objects/BuiltElements/Revit/RevitConduit.cs b/src/Speckle.Objects/BuiltElements/Revit/RevitConduit.cs
@@ -10,6 +10,7 @@ public class RevitConduit : Conduit, IHasMEPConnectors
 
   public string type { get; set; }
 
+  [DetachProperty]
   public Level level { get; set; }
 
   public Base parameters { get; set; }

diff --git a/src/Speckle.Objects/BuiltElements/Revit/RevitDuct.cs b/src/Speckle.Objects/BuiltElements/Revit/RevitDuct.cs
@@ -43,6 +43,8 @@ public RevitDuct(
   public string type { get; set; }
   public string systemName { get; set; }
   public string systemType { get; set; }
+
+  [DetachProperty]
   public Level level { get; set; }
   public Base? parameters { get; set; }
   public string? elementId { get; set; }

diff --git a/src/Speckle.Objects/BuiltElements/Revit/RevitOpening.cs b/src/Speckle.Objects/BuiltElements/Revit/RevitOpening.cs
@@ -84,7 +84,10 @@ public RevitShaft(
     this.parameters = parameters?.ToBase();
   }
 
+  [DetachProperty]
   public Level bottomLevel { get; set; }
+
+  [DetachProperty]
   public Level topLevel { get; set; }
   public double height { get; set; }
 

diff --git a/src/Speckle.Objects/BuiltElements/Revit/RevitPipe.cs b/src/Speckle.Objects/BuiltElements/Revit/RevitPipe.cs
@@ -39,6 +39,8 @@ public RevitPipe(
   public string systemType { get; set; }
   public Base? parameters { get; set; }
   public string elementId { get; set; }
+
+  [DetachProperty]
   public Level level { get; set; }
   public List<RevitMEPConnector> Connectors { get; set; } = new();
 }

diff --git a/src/Speckle.Objects/BuiltElements/Revit/RevitRailing.cs b/src/Speckle.Objects/BuiltElements/Revit/RevitRailing.cs
@@ -20,6 +20,8 @@ public RevitRailing(string type, [SchemaMainParam] Polycurve baseCurve, Level le
 
   //public string family { get; set; }
   public string type { get; set; }
+
+  [DetachProperty]
   public Level level { get; set; }
   public Polycurve path { get; set; }
   public bool flipped { get; set; }

diff --git a/src/Speckle.Objects/BuiltElements/Revit/RevitStair.cs b/src/Speckle.Objects/BuiltElements/Revit/RevitStair.cs
@@ -8,7 +8,11 @@ public class RevitStair : Base, IDisplayValue<List<Mesh>>
 {
   public string family { get; set; }
   public string type { get; set; }
+
+  [DetachProperty]
   public Level level { get; set; }
+
+  [DetachProperty]
   public Level topLevel { get; set; }
   public double riserHeight { get; set; }
   public int risersNumber { get; set; }

diff --git a/src/Speckle.Objects/BuiltElements/Revit/RevitToposolid.cs b/src/Speckle.Objects/BuiltElements/Revit/RevitToposolid.cs
@@ -38,6 +38,8 @@ public RevitToposolid(
 
   public string family { get; set; }
   public string type { get; set; }
+
+  [DetachProperty]
   public Level level { get; set; }
   public Base? parameters { get; set; }
 }
diff --git a/src/Speckle.Objects/BuiltElements/Revit/RevitWall.cs b/src/Speckle.Objects/BuiltElements/Revit/RevitWall.cs
@@ -46,6 +46,8 @@ public RevitWall(
   public double topOffset { get; set; }
   public bool flipped { get; set; }
   public bool structural { get; set; }
+
+  [DetachProperty]
   public Level? topLevel { get; set; }
   public Base? parameters { get; set; }
   public string? elementId { get; set; }
@@ -211,6 +213,7 @@ public RevitProfileWall(
   public string type { get; set; }
   public Polycurve profile { get; set; }
 
+  [DetachProperty]
   public new Level? level
   {
     get => base.level;

diff --git a/src/Speckle.Objects/BuiltElements/Revit/RevitWire.cs b/src/Speckle.Objects/BuiltElements/Revit/RevitWire.cs
@@ -33,6 +33,8 @@ public RevitWire(
   public string wiringType { get; set; }
   public List<double> constructionPoints { get; set; } // used in constructor for revit native wires
   public string system { get; set; }
+
+  [DetachProperty]
   public Level level { get; set; }
   public Base? parameters { get; set; }
   public string elementId { get; set; }

diff --git a/src/Speckle.Objects/BuiltElements/Revit/RevitZone.cs b/src/Speckle.Objects/BuiltElements/Revit/RevitZone.cs
@@ -7,6 +7,7 @@ public class RevitZone : Zone
 {
   public RevitZone() { }
 
+  [DetachProperty]
   public Level level { get; set; }
   public string phaseName { get; set; }
   public Base parameters { get; set; }

diff --git a/src/Speckle.Objects/BuiltElements/Space.cs b/src/Speckle.Objects/BuiltElements/Space.cs
@@ -47,8 +47,12 @@ double baseOffset
   public string name { get; set; }
   public string number { get; set; }
   public Point basePoint { get; set; }
+
+  [DetachProperty]
   public Level level { get; set; }
   public double baseOffset { get; set; }
+
+  [DetachProperty]
   public Level topLevel { get; set; } // corresponds to UpperLimit property in Revit api
   public double topOffset { get; set; } // corresponds to LimitOffset property in Revit api
   public List<ICurve> voids { get; set; } = new();

diff --git a/src/Speckle.Objects/BuiltElements/Wall.cs b/src/Speckle.Objects/BuiltElements/Wall.cs
@@ -30,6 +30,8 @@ public Wall(
 
   public string? units { get; set; }
   public ICurve baseLine { get; set; }
+
+  [DetachProperty]
   public virtual Level? level { get; internal set; }
 
   [DetachProperty]

diff --git a/src/Speckle.Objects/Other/Revit/RevitInstance.cs b/src/Speckle.Objects/Other/Revit/RevitInstance.cs
@@ -9,6 +9,7 @@ namespace Speckle.Objects.Other.Revit;
 [SpeckleType("Objects.Other.Revit.RevitInstance")]
 public class RevitInstance : Instance<RevitSymbolElementType>
 {
+  [DetachProperty]
   public Level level { get; set; }
   public bool facingFlipped { get; set; }
   public bool handFlipped { get; set; }