Skip to content

Commit

Permalink
Obsolete warnings (#156)
Browse files Browse the repository at this point in the history
  • Loading branch information
JR-Morgan authored Nov 6, 2024
1 parent 4cc78c4 commit d659933
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 10 deletions.
2 changes: 0 additions & 2 deletions .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -257,8 +257,6 @@ dotnet_diagnostic.ca1509.severity = warning # Invalid entry in code metrics conf
dotnet_diagnostic.ca1861.severity = none # Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly and is not mutating the passed array (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1861)

dotnet_diagnostic.cs8618.severity = suggestion # nullable problem
dotnet_diagnostic.CS0809.severity = suggestion # obsolete errors
dotnet_diagnostic.CS0618.severity = suggestion # obsolete errors


# Performance rules
Expand Down
5 changes: 0 additions & 5 deletions src/Speckle.Objects/GIS/RasterLayer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,4 @@ public class RasterLayer : Collection
public CRS? rasterCrs { get; set; }
public string? geomType { get; set; }
public Dictionary<string, object>? renderer { get; set; }

public RasterLayer()
{
collectionType = "RasterLayer";
}
}
1 change: 0 additions & 1 deletion src/Speckle.Objects/GIS/VectorLayer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ public class VectorLayer : Collection

public VectorLayer()
{
collectionType = "VectorLayer";
attributes = new Base();
}
}
2 changes: 1 addition & 1 deletion src/Speckle.Sdk/Api/GraphQL/Resources/VersionResource.cs
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ mutation MarkReceived($input: MarkReceivedVersionInput!) {
return response.data.data;
}

[Obsolete("modelId is no longer required, use the overload that doesn't specify a model id")]
[Obsolete("modelId is no longer required, use the overload that doesn't specify a model id", true)]
public Task<Version> Get(
string versionId,
string modelId,
Expand Down
1 change: 0 additions & 1 deletion src/Speckle.Sdk/Models/DynamicBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,6 @@ public unsafe bool IsPropNameValid(string name, out string reason)
/// <summary>
/// Gets all of the property names on this class, dynamic or not.
/// </summary> <returns></returns>
[Obsolete("Use `GetMembers(DynamicBaseMemberType.All).Keys` instead")]
public override IEnumerable<string> GetDynamicMemberNames()
{
var pinfos = TypeLoader.GetBaseProperties(GetType());
Expand Down

0 comments on commit d659933

Please sign in to comment.