Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge sharp dui3/alpha -> sdk main #16

Merged
merged 5 commits into from
Jul 9, 2024
Merged

Conversation

JR-Morgan
Copy link
Member

@JR-Morgan JR-Morgan commented Jul 8, 2024

Manual Merge from dui3/alpha, mostly containing specklesystems/speckle-sharp#3562
Some quick fixes (nullability syntax)
I've also tweaked the way we tell polysharp to create the IsExternalInit... this will allow us to use it in Core.. but may potentially stop us using in the test projects. I figured this was a better way round...

@JR-Morgan JR-Morgan requested a review from BovineOx July 8, 2024 19:45
Copy link

gitguardian bot commented Jul 8, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
455155 Triggered Generic Password b1e69e6 tests/Speckle.Core.Tests.Integration/Fixtures.cs View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 18.92393% with 437 lines in your changes missing coverage. Please review.

Project coverage is 27.43%. Comparing base (29e7e84) to head (02c396d).

Files Patch % Lines
...peckle.Core/Api/GraphQL/Resources/ModelResource.cs 4.91% 58 Missing ⚠️
...ckle.Core/Api/GraphQL/Resources/VersionResource.cs 5.08% 56 Missing ⚠️
...ckle.Core/Api/GraphQL/Resources/ProjectResource.cs 5.35% 53 Missing ⚠️
...ckle.Core/Api/GraphQL/Resources/CommentResource.cs 5.76% 49 Missing ⚠️
...e.Core/Api/GraphQL/Resources/ActiveUserResource.cs 8.82% 31 Missing ⚠️
...Core/Api/GraphQL/Resources/SubscriptionResource.cs 15.62% 26 Missing and 1 partial ⚠️
src/Speckle.Core/Api/GraphQL/Client.cs 70.11% 25 Missing and 1 partial ⚠️
...c/Speckle.Core/Api/GraphQL/Inputs/ProjectInputs.cs 0.00% 26 Missing ⚠️
...ore/Api/GraphQL/Resources/ProjectInviteResource.cs 11.11% 24 Missing ⚠️
...le.Core/Api/GraphQL/Resources/OtherUserResource.cs 11.53% 23 Missing ⚠️
... and 11 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   27.78%   27.43%   -0.35%     
==========================================
  Files         358      373      +15     
  Lines       14190    14483     +293     
  Branches     1388     1400      +12     
==========================================
+ Hits         3943     3974      +31     
- Misses       9976    10236     +260     
- Partials      271      273       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -4,6 +4,7 @@
<TargetFramework>net8.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<IsTestProject>true</IsTestProject>
<PolySharpExcludeGeneratedTypes>System.Runtime.CompilerServices.IsExternalInit;System.Runtime.CompilerServices.RequiresLocationAttribute</PolySharpExcludeGeneratedTypes>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we can move this to the DIrectory.Build.Props file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only need this for the projects that core has InternalsVisibleTo attributes declared on. So technically not all test projects will need this. But.. if you think its simpler, I don't mind adding it there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, let's not too that. I'd rather not have InternalsVisibileTo anyway but can avoid it for now

@adamhathcock adamhathcock merged commit 1268a08 into main Jul 9, 2024
3 of 4 checks passed
@adamhathcock adamhathcock deleted the jrm/dui3-alpha-to-sdk branch July 9, 2024 11:32
adamhathcock added a commit that referenced this pull request Jul 9, 2024
* Add Instances base (#6)

* Use Uri for checks in GetAccounts function (#8)

* Add integration and perf tests to sln (#9)

* Remove perf tests (#10)

* remove perf tests

* do all unit tests

* Code coverage (#11)

* code coverage

* enable codecov for GA

* Update README.md

* Update coverage and dependencies (#12)

* Update coverage and dependencies

* fmt

* add codecov config

* merge DUI3/Alpha into sdk (#13)

* merge DUI3/Alpha into sdk

* formatting

* Merge Objects dui3/alpha -> dev (#14)

* merge DUI3/Alpha into sdk

* formatting

* Objects changes

* Objects tests

* Unit test project

* update codecov to be less intrusive (#15)

* update codecov to be less intrusive

* fix codecov yaml

* add coverage exclusion

* Merge sharp `dui3/alpha` -> sdk `main` (#16)

* Merge

* csharpier format

* Fixed polysharp issues

* Integration Tests

* Fixes

* Some nullability fixes (#17)

* add coverage exclusion

* fix some tests and fix nullability errors

---------

Co-authored-by: Oğuzhan Koral <[email protected]>
Co-authored-by: Jedd Morgan <[email protected]>
adamhathcock added a commit that referenced this pull request Jul 10, 2024
* Add Instances base (#6)

* Use Uri for checks in GetAccounts function (#8)

* Add integration and perf tests to sln (#9)

* Remove perf tests (#10)

* remove perf tests

* do all unit tests

* Code coverage (#11)

* code coverage

* enable codecov for GA

* Update README.md

* Update coverage and dependencies (#12)

* Update coverage and dependencies

* fmt

* add codecov config

* merge DUI3/Alpha into sdk (#13)

* merge DUI3/Alpha into sdk

* formatting

* Merge Objects dui3/alpha -> dev (#14)

* merge DUI3/Alpha into sdk

* formatting

* Objects changes

* Objects tests

* Unit test project

* add coverage exclusion

* fix some tests and fix nullability errors

* update codecov to be less intrusive (#15)

* update codecov to be less intrusive

* fix codecov yaml

* add coverage exclusion

* Merge sharp `dui3/alpha` -> sdk `main` (#16)

* Merge

* csharpier format

* Fixed polysharp issues

* Integration Tests

* Fixes

* add build for docker compose

* add integration tests

* remove extra services

* update healthcheck for server

---------

Co-authored-by: Oğuzhan Koral <[email protected]>
Co-authored-by: Jedd Morgan <[email protected]>
adamhathcock added a commit that referenced this pull request Jul 10, 2024
… logging level (#20)

* Add Integration tests to CI (#19)

* Add Instances base (#6)

* Use Uri for checks in GetAccounts function (#8)

* Add integration and perf tests to sln (#9)

* Remove perf tests (#10)

* remove perf tests

* do all unit tests

* Code coverage (#11)

* code coverage

* enable codecov for GA

* Update README.md

* Update coverage and dependencies (#12)

* Update coverage and dependencies

* fmt

* add codecov config

* merge DUI3/Alpha into sdk (#13)

* merge DUI3/Alpha into sdk

* formatting

* Merge Objects dui3/alpha -> dev (#14)

* merge DUI3/Alpha into sdk

* formatting

* Objects changes

* Objects tests

* Unit test project

* add coverage exclusion

* fix some tests and fix nullability errors

* update codecov to be less intrusive (#15)

* update codecov to be less intrusive

* fix codecov yaml

* add coverage exclusion

* Merge sharp `dui3/alpha` -> sdk `main` (#16)

* Merge

* csharpier format

* Fixed polysharp issues

* Integration Tests

* Fixes

* add build for docker compose

* add integration tests

* remove extra services

* update healthcheck for server

---------

Co-authored-by: Oğuzhan Koral <[email protected]>
Co-authored-by: Jedd Morgan <[email protected]>

* Don't run non-int tests during int tests.  Reduce logging level

---------

Co-authored-by: Oğuzhan Koral <[email protected]>
Co-authored-by: Jedd Morgan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants