Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gis objects cleaning #181

Merged
merged 11 commits into from
Jan 10, 2025
Merged

Gis objects cleaning #181

merged 11 commits into from
Jan 10, 2025

Conversation

KatKatKateryna
Copy link
Contributor

@KatKatKateryna KatKatKateryna commented Nov 28, 2024

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.13%. Comparing base (14d9598) to head (40a11ef).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #181       +/-   ##
===========================================
+ Coverage   57.06%   69.13%   +12.07%     
===========================================
  Files         249      259       +10     
  Lines       10061    10743      +682     
  Branches     1090     1091        +1     
===========================================
+ Hits         5741     7427     +1686     
+ Misses       4063     2969     -1094     
- Partials      257      347       +90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

adamhathcock
adamhathcock previously approved these changes Nov 28, 2024
Copy link
Member

@adamhathcock adamhathcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/Speckle.Objects/GIS/CRS.cs Outdated Show resolved Hide resolved
src/Speckle.Objects/GIS/GisLayer.cs Outdated Show resolved Hide resolved
src/Speckle.Objects/Geometry/Polygon.cs Outdated Show resolved Hide resolved
@JR-Morgan JR-Morgan enabled auto-merge (squash) January 10, 2025 15:10
@JR-Morgan JR-Morgan dismissed clairekuang’s stale review January 10, 2025 15:33

Resolved or files deleted

@JR-Morgan JR-Morgan merged commit deddb21 into dev Jan 10, 2025
4 checks passed
@JR-Morgan JR-Morgan deleted the gis_objects_cleaning branch January 10, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants