Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bjorn/csi interface #182

Closed
wants to merge 2 commits into from
Closed

bjorn/csi interface #182

wants to merge 2 commits into from

Conversation

bjoernsteinhagen
Copy link
Contributor

  • Related to CNX-835
  • CSiObject common for both ETABS and SAP 2000
  • cPointObj, cFrameObj, cAreaObj, etc. are all independent objects
  • They don't have a native parent-child hierarchy like Tekla or Revit. Relationships (like Points being part of a Frame) exist but these aren't parent-child relationships. No need for elements.

- Adding ICSiObject for ETABS and SAP 2000
- cPointObj, cFrameObj, cAreaObj, etc. are all independent objects. They don't have a native parent-child hierarchy like Tekla or Revit (i.e. no `elements`)
Copy link

linear bot commented Nov 28, 2024

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.50%. Comparing base (7bbc568) to head (f128a53).
Report is 12 commits behind head on dev.

Files with missing lines Patch % Lines
src/Speckle.Objects/Data/CSiObject.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #182       +/-   ##
===========================================
+ Coverage   53.89%   66.50%   +12.60%     
===========================================
  Files         230      247       +17     
  Lines        9335     9983      +648     
  Branches     1071     1072        +1     
===========================================
+ Hits         5031     6639     +1608     
+ Misses       4049     2990     -1059     
- Partials      255      354       +99     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bjoernsteinhagen
Copy link
Contributor Author

Discussed with @AlanRynne this morning, let's not merge just yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant