Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullable fixes - nullability on Base #184

Merged
merged 12 commits into from
Dec 3, 2024
Merged

Nullable fixes - nullability on Base #184

merged 12 commits into from
Dec 3, 2024

Conversation

adamhathcock
Copy link
Member

No description provided.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 63.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 66.26%. Comparing base (daec64c) to head (22880bd).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...Speckle.Sdk/Api/GraphQL/Serializer/MapConverter.cs 0.00% 6 Missing and 1 partial ⚠️
src/Speckle.Sdk/Credentials/Account.cs 0.00% 1 Missing ⚠️
src/Speckle.Sdk/Credentials/AccountManager.cs 0.00% 1 Missing ⚠️
src/Speckle.Sdk/Host/Attributes.cs 0.00% 1 Missing ⚠️
...ckle.Sdk/Serialisation/V2/Send/ObjectSerializer.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #184       +/-   ##
===========================================
+ Coverage   53.67%   66.26%   +12.59%     
===========================================
  Files         233      249       +16     
  Lines        9370    10014      +644     
  Branches     1074     1066        -8     
===========================================
+ Hits         5029     6636     +1607     
+ Misses       4087     3032     -1055     
- Partials      254      346       +92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamhathcock adamhathcock changed the title Nullable fixes - remove Point extras and nullability on Base Nullable fixes - nullability on Base Dec 3, 2024
src/Speckle.Sdk/Credentials/Account.cs Outdated Show resolved Hide resolved
JR-Morgan
JR-Morgan previously approved these changes Dec 3, 2024
@adamhathcock adamhathcock merged commit d904c68 into dev Dec 3, 2024
2 checks passed
@adamhathcock adamhathcock deleted the nullable_fixes branch December 3, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants