Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details to sqlite exceptions #198

Merged
merged 36 commits into from
Jan 9, 2025
Merged

Add details to sqlite exceptions #198

merged 36 commits into from
Jan 9, 2025

Conversation

adamhathcock
Copy link
Member

@adamhathcock adamhathcock commented Jan 3, 2025

get prettier logs
image

requires #193

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 68.38%. Comparing base (ed5bdc9) to head (b5060c4).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
src/Speckle.Sdk/SQLite/SqLiteJsonCacheException.cs 37.50% 3 Missing and 7 partials ⚠️
src/Speckle.Sdk/SQLite/CacheDbCommandPool.cs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #198       +/-   ##
===========================================
+ Coverage   56.28%   68.38%   +12.09%     
===========================================
  Files         244      263       +19     
  Lines        9879    10658      +779     
  Branches     1086     1094        +8     
===========================================
+ Hits         5560     7288     +1728     
+ Misses       4063     3015     -1048     
- Partials      256      355       +99     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamhathcock adamhathcock marked this pull request as ready for review January 8, 2025 11:08
@adamhathcock adamhathcock enabled auto-merge (squash) January 8, 2025 15:39
@adamhathcock adamhathcock merged commit 465f635 into dev Jan 9, 2025
4 checks passed
@adamhathcock adamhathcock deleted the add-details-sqlite branch January 9, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants