feat(objects): cnx 931 create archicadobject #200
+28
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also removes unused gis classes
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #200 +/- ##
===========================================
+ Coverage 57.26% 69.07% +11.80%
===========================================
Files 243 260 +17
Lines 10023 10741 +718
Branches 1090 1091 +1
===========================================
+ Hits 5740 7419 +1679
+ Misses 4026 2975 -1051
- Partials 257 347 +90 ☔ View full report in Codecov by Sentry. |
oguzhankoral
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
ArchicadObject : DataObjectclass and its corresponding interface to allow for precise deserialization in speckle sharp.Also removes unused arcgis classes and interface.
Wait to merge: