Removed GIS classes #201
Closed
Removed GIS classes #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-merge was automatically disabled
January 10, 2025 15:08
Pull request was closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #201 +/- ##
===========================================
+ Coverage 57.06% 69.13% +12.07%
===========================================
Files 249 259 +10
Lines 10061 10743 +682
Branches 1090 1091 +1
===========================================
+ Hits 5741 7427 +1686
+ Misses 4063 2969 -1094
- Partials 257 347 +90 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have several GIS classes that are unused,
and instead of fixing them to have the correct
requiredkeyword applied to them, I think we can kill them.The converters for these types were removed from ArcGIS a short while ago (as they were only an attempt to maintain backwards compatibility with v2)