Jedd/cxpla 154 enforce nullability analysers in objects and use required #202
+44
−50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables for the
Speckle.Objects
project the remaining nullability analysers for ensuring correct nullability and use ofrequired
keyword of our object models.CS8618 - Non-nullable variable must contain a non-null value when exiting constructor.
required
keyword for Pontcloud and SurfaceSurface
class has some complex behaviour around the flattening the control point data for efficient serilization. For now I've had to expose a parametered constructor in addition torequired
properties, we could simplyfy this by re-structuring the class a little.