Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jedd/cxpla 154 enforce nullability analysers in objects and use required #202

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

JR-Morgan
Copy link
Member

Enables for the Speckle.Objects project the remaining nullability analysers for ensuring correct nullability and use of required keyword of our object models.

CS8618 - Non-nullable variable must contain a non-null value when exiting constructor.

  • Enable CS8618 for Objects, still supressed for SDK
  • Added required keyword for Pontcloud and Surface
  • Surface class has some complex behaviour around the flattening the control point data for efficient serilization. For now I've had to expose a parametered constructor in addition to required properties, we could simplyfy this by re-structuring the class a little.

Copy link

linear bot commented Jan 10, 2025

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 69.13%. Comparing base (deddb21) to head (912971d).

Files with missing lines Patch % Lines
src/Speckle.Objects/Geometry/Surface.cs 0.00% 20 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #202       +/-   ##
===========================================
+ Coverage   57.29%   69.13%   +11.84%     
===========================================
  Files         243      259       +16     
  Lines       10020    10742      +722     
  Branches     1090     1091        +1     
===========================================
+ Hits         5741     7427     +1686     
+ Misses       4022     2968     -1054     
- Partials      257      347       +90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant