Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SDK to report requested downloaded objects and minor adjustments #203

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

adamhathcock
Copy link
Member

Allows for
image

JR-Morgan
JR-Morgan previously approved these changes Jan 13, 2025
@adamhathcock adamhathcock merged commit 4370af5 into dev Jan 13, 2025
2 checks passed
@adamhathcock adamhathcock deleted the fix-download-percetage branch January 13, 2025 12:48
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 69.05%. Comparing base (deddb21) to head (84c6245).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...eckle.Sdk/Serialisation/V2/Receive/ObjectLoader.cs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #203       +/-   ##
===========================================
+ Coverage   57.29%   69.05%   +11.76%     
===========================================
  Files         243      259       +16     
  Lines       10020    10739      +719     
  Branches     1090     1091        +1     
===========================================
+ Hits         5741     7416     +1675     
+ Misses       4022     2974     -1048     
- Partials      257      349       +92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants