Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a task.yield for a cached model to let progress happen #204

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

adamhathcock
Copy link
Member

adding this seems to fix a Revit only issue of updating deserialization progress when the model is cached locally

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.06%. Comparing base (4370af5) to head (35f8ef7).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...eckle.Sdk/Serialisation/V2/Receive/ObjectLoader.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #204       +/-   ##
===========================================
+ Coverage   57.27%   69.06%   +11.79%     
===========================================
  Files         243      259       +16     
  Lines       10022    10740      +718     
  Branches     1090     1091        +1     
===========================================
+ Hits         5740     7418     +1678     
+ Misses       4025     2974     -1051     
- Partials      257      348       +91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@didimitrie didimitrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking innocent enough

@adamhathcock adamhathcock merged commit b3c6a75 into dev Jan 14, 2025
4 checks passed
@adamhathcock adamhathcock deleted the fix-cached-progress branch January 14, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants