Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental - Refactor ITransformable #205

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

JR-Morgan
Copy link
Member

No description provided.

Copy link

linear bot commented Jan 15, 2025

@JR-Morgan JR-Morgan changed the title Jedd/cnx 887 100 unit test coverage in objects Experimental - Refactor ITransformable Jan 15, 2025
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 13.60000% with 108 lines in your changes missing coverage. Please review.

Project coverage is 69.33%. Comparing base (deddb21) to head (c31d0a0).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
src/Speckle.Objects/Geometry/Surface.cs 0.00% 22 Missing ⚠️
src/Speckle.Objects/Geometry/Brep.cs 0.00% 13 Missing ⚠️
src/Speckle.Objects/Geometry/Curve.cs 0.00% 11 Missing ⚠️
src/Speckle.Objects/Geometry/Mesh.cs 0.00% 11 Missing ⚠️
src/Speckle.Objects/Geometry/Pointcloud.cs 0.00% 9 Missing ⚠️
src/Speckle.Objects/Geometry/Polyline.cs 0.00% 9 Missing ⚠️
src/Speckle.Objects/Geometry/Polycurve.cs 0.00% 8 Missing ⚠️
src/Speckle.Objects/Geometry/Arc.cs 0.00% 6 Missing ⚠️
src/Speckle.Objects/Geometry/Plane.cs 0.00% 5 Missing ⚠️
...ckle.Objects/Exceptions/TransformationException.cs 0.00% 3 Missing ⚠️
... and 5 more
Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #205       +/-   ##
===========================================
+ Coverage   57.29%   69.33%   +12.04%     
===========================================
  Files         243      262       +19     
  Lines       10020    10729      +709     
  Branches     1090     1091        +1     
===========================================
+ Hits         5741     7439     +1698     
+ Misses       4022     2943     -1079     
- Partials      257      347       +90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

/// <remarks>
/// Do not inherit directly, inherit from <see cref="ITransformable{T}"/> instead
/// </remarks>
public interface ITransformable : ISpeckleObject { }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why have this at all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants