Serialize now waits for the scheduler to be completed before returning #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #225 +/- ##
===========================================
+ Coverage 59.58% 70.79% +11.20%
===========================================
Files 262 278 +16
Lines 10460 11205 +745
Branches 1105 1108 +3
===========================================
+ Hits 6233 7933 +1700
+ Misses 3964 2918 -1046
- Partials 263 354 +91 ☔ View full report in Codecov by Sentry. |
…hannels are empty
|
I think the empty message ensures all messages are complete and prevents the unstable tests |
|
Testing (normal sends, concurrent sends, send cancellation)
|
JR-Morgan
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to stop occasional indeterminate tests 😬
Cancellation for download should be snappier as the token is listened to and the stream happens asap with ResponseHeadersRead
Changing the Receive to a PriorityScheduler has it's own thread pool. The default scheduler/thread pool is swamped by Tasks so the CEF progress isn't updated to the end. Changing schedulers fixes that.