Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batches size now affects sending size accurately. Use extensions to … #230

Merged
merged 4 commits into from
Feb 17, 2025

Conversation

adamhathcock
Copy link
Member

@adamhathcock adamhathcock commented Feb 17, 2025

…help test this

This was fixed but had a regression

This caused a single request to be too big sometimes and it was noticeable on large models. This fix says anything larger than 25 is 25 so an individual request won't be (much) larger than 25 megs. There are tests now to prevent this being reverted again.

Copy link

linear bot commented Feb 17, 2025

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.93%. Comparing base (e5a0915) to head (1d80b44).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #230       +/-   ##
===========================================
+ Coverage   59.67%   70.93%   +11.25%     
===========================================
  Files         262      279       +17     
  Lines       10489    11256      +767     
  Branches     1107     1109        +2     
===========================================
+ Hits         6259     7984     +1725     
+ Misses       3969     2919     -1050     
- Partials      261      353       +92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JR-Morgan
Copy link
Member

JR-Morgan commented Feb 17, 2025

  • Rhino Sends - Confirmed fixes large send issue

  • I would like to debug some more to measure what size of batches we are now sending
    Confirmed, not a single batch was over 20MiB

@adamhathcock
Copy link
Member Author

25 meg or less if nothing is larger than 25 meg.

Batches could be over that if a single message is over 25 megs 😬

@adamhathcock adamhathcock enabled auto-merge (squash) February 17, 2025 15:40
@adamhathcock adamhathcock merged commit 87ae033 into dev Feb 17, 2025
4 checks passed
@adamhathcock adamhathcock deleted the adam/cxpla-166-v3-large-models-413 branch February 17, 2025 15:52
@adamhathcock
Copy link
Member Author

this adds logging as a warning for large requests: #232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants