Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NET core target to return IReadonlySet for freeze #233

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

JR-Morgan
Copy link
Member

@JR-Morgan JR-Morgan commented Feb 17, 2025

Net 5 introduced the IReadOnlySet<T> interface which inherits IReadOnlyCollection<T>.
Since we now have NET8 only consumers (IFC importer), it would be nice to use this new interface

@JR-Morgan JR-Morgan enabled auto-merge (squash) February 17, 2025 16:46
@JR-Morgan JR-Morgan merged commit 358680c into dev Feb 17, 2025
2 checks passed
@JR-Morgan JR-Morgan deleted the jrm/frozenset-ireadonlyset branch February 17, 2025 16:56
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.94%. Comparing base (87ae033) to head (2222905).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #233       +/-   ##
===========================================
+ Coverage   59.85%   70.94%   +11.09%     
===========================================
  Files         263      279       +16     
  Lines       10540    11256      +716     
  Branches     1108     1109        +1     
===========================================
+ Hits         6309     7986     +1677     
+ Misses       3970     2918     -1052     
- Partials      261      352       +91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JR-Morgan
Copy link
Member Author

Motivation:
IFC parser, I want to use a IReadOnlySet to make it clear its cheap to do contains, and unnecessary to do distinct, but since Freeze returns image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants