fix(rvt): Updates leftover GenericModels category references in Rev…

…it conversions. (#2138) fix(revit): Leftover `GenericModels` category changed for singular `GenericModel`
specklesystems · Feb 10, 2023 · 36e8a97 · 36e8a97
1 parent e537455
commit 36e8a97
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/Objects/Converters/ConverterRevit/ConverterRevitShared/Partial Classes/ConvertDirectShape.cs b/Objects/Converters/ConverterRevit/ConverterRevitShared/Partial Classes/ConvertDirectShape.cs
@@ -95,7 +95,7 @@ public ApplicationObject DirectShapeToNative(DirectShape speckleDs, ToNativeMesh
 
       BuiltInCategory bic;
       if ((int)speckleDs.category == -1)
-        speckleDs.category = RevitCategory.GenericModels;
+        speckleDs.category = RevitCategory.GenericModel;
       var bicName = Categories.GetBuiltInFromSchemaBuilderCategory(speckleDs.category);
 
       BuiltInCategory.TryParse(bicName, out bic);

diff --git a/.../Converters/ConverterRevit/ConverterRevitShared/Partial Classes/ConvertFreeformElement.cs b/.../Converters/ConverterRevit/ConverterRevitShared/Partial Classes/ConvertFreeformElement.cs
@@ -181,7 +181,7 @@ private string CreateFreeformElementFamily(List<DB.Solid> solids, string name, o
           {
             //by default free form elements are always generic models
             //otherwise we'd need to supply base files for each category..?
-            var bicName = Categories.GetBuiltInFromSchemaBuilderCategory(BuiltElements.Revit.RevitCategory.GenericModels);
+            var bicName = Categories.GetBuiltInFromSchemaBuilderCategory(BuiltElements.Revit.RevitCategory.GenericModel);
             BuiltInCategory.TryParse(bicName, out bic);
             cat = famDoc.Settings.Categories.get_Item(bic);
             if (cat.SubCategories.Contains(freeformElement.subcategory))
@@ -209,4 +209,4 @@ private string CreateFreeformElementFamily(List<DB.Solid> solids, string name, o
       return tempFamilyPath;
     }
   }
-}
+}