Skip to content

Commit

Permalink
fix(rhino): mapping constraints on polylines and facewalls (#2769)
Browse files Browse the repository at this point in the history
removes polyline assignment and constrains facewall to basic wall types
  • Loading branch information
clairekuang authored Jul 13, 2023
1 parent a9513f6 commit 3ef07cb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,9 @@ private List<Schema> GetObjectSchemas(RhinoObject obj)
result.Add(new RevitDefaultPipeViewModel());
result.Add(new RevitDefaultDuctViewModel());
}
else if (c.IsPlanar())
else if (c.IsPlanar() && !c.IsPolyline())
{
// If the curve is non-linear, but is planar, it can still be a beam.
// If the curve is non-linear, but is planar and is not a polyline, it can still be a beam.
result.Add(new RevitDefaultBeamViewModel());
result.Add(new RevitBeamViewModel());
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ schema is DirectShapeFreeformViewModel
break;

case RevitFaceWallViewModel o:
var faceWallFamilies = AvailableRevitTypes.Where(x => x.category == "Walls").ToList();
var faceWallFamilies = AvailableRevitTypes.Where(x => x.family == "Basic Wall").ToList();
if (!faceWallFamilies.Any() || !AvailableRevitLevels.Any())
break;
var faceWallFamiliesViewModels = faceWallFamilies
Expand Down

0 comments on commit 3ef07cb

Please sign in to comment.