fixes curves!

specklesystems · Jun 20, 2024 · 449b396 · 449b396
1 parent b6a191d
commit 449b396
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/DUI3-DX/Converters/Rhino/Speckle.Converters.Rhino7/ToSpeckle/Raw/NurbsCurveConverter.cs b/DUI3-DX/Converters/Rhino/Speckle.Converters.Rhino7/ToSpeckle/Raw/NurbsCurveConverter.cs
@@ -40,10 +40,6 @@ IRhinoBoxFactory rhinoBoxFactory
   public SOG.Curve Convert(IRhinoNurbsCurve target)
   {
     target.ToPolyline(0, 1, 0, 0, 0, 0.1, 0, 0, true).TryGetPolyline(out var poly);
-    if (target.IsClosed)
-    {
-      poly.Add(poly[0]);
-    }
 
     SOG.Polyline displayValue = _polylineConverter.Convert(poly);
 

diff --git a/...DX/Converters/Rhino/Speckle.Converters.Rhino7/ToSpeckle/Raw/PolylineToSpeckleConverter.cs b/...DX/Converters/Rhino/Speckle.Converters.Rhino7/ToSpeckle/Raw/PolylineToSpeckleConverter.cs
@@ -40,7 +40,7 @@ public SOG.Polyline Convert(IRhinoPolyline target)
     var box = _boxConverter.Convert(_rhinoBoxFactory.CreateBox(target.BoundingBox));
     var points = target.Select(pt => _pointConverter.Convert(pt)).ToList();
 
-    if (target.IsClosed)
+    if (points[0] == points[^1] && target.IsClosed)
     {
       points.RemoveAt(points.Count - 1);
     }