Add baseline to Column

specklesystems · Sep 8, 2023 · be55cad · be55cad
1 parent b5fd27a
commit be55cad
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/ConnectorArchicad/ConnectorArchicad/Converters/Converters/ColumnConverter.cs b/ConnectorArchicad/ConnectorArchicad/Converters/Converters/ColumnConverter.cs
@@ -72,7 +72,7 @@ await AsyncCommandProcessor.Execute(
         column.displayValue =
           Operations.ModelConverter.MeshesToSpeckle(elementModels.First(e => e.applicationId == column.applicationId)
             .model);
-        //column.baseLine = ...
+        column.baseLine = new Line(column.origoPos, column.origoPos + new Point (0, 0, column.height));
         columns.Add(column);
       }
 

diff --git a/Objects/Converters/ConverterRevit/ConverterRevitShared/Partial Classes/ConvertColumn.cs b/Objects/Converters/ConverterRevit/ConverterRevitShared/Partial Classes/ConvertColumn.cs
@@ -159,7 +159,7 @@ public ApplicationObject ColumnToNative(Column speckleColumn)
       }
       else
       {
-        SetOffsets(revitColumn, level, topLevel, -baseOffset, -topOffset);
+        // this case is always line based, don't change offset for line based columns, it's automatic
       }
 
       var state = isUpdate ? ApplicationObject.State.Updated : ApplicationObject.State.Created;
-Original file line number
+Diff line change
@@ Expand Up @@
           }
           else
           {
-            SetOffsets(revitColumn, level, topLevel, -baseOffset, -topOffset);
+            // this case is always line based, don't change offset for line based columns, it's automatic
           }
           var state = isUpdate ? ApplicationObject.State.Updated : ApplicationObject.State.Created;
@@ Expand Down @@