fix(dui2/rhino): preview and report bugs (#1582)

* preview bug fixes for rhino * updated all connector bindings * Update ConnectorBindingsTeklaStructure.Send.cs
specklesystems · Sep 5, 2022 · fbe528f · fbe528f
1 parent 466ff9c
commit fbe528f
Show file tree

Hide file tree

Showing 15 changed files with 187 additions and 64 deletions.
diff --git a/ConnectorArchicad/ConnectorArchicad/ConnectorBinding.cs b/ConnectorArchicad/ConnectorArchicad/ConnectorBinding.cs
@@ -98,10 +98,10 @@ public override List<ReceiveMode> GetReceiveModes()
       return new List<ReceiveMode> { ReceiveMode.Create };
     }
 
+    public override bool CanPreviewReceive => false;
     public override Task<StreamState> PreviewReceive(StreamState state, ProgressViewModel progress)
     {
       return null;
-      // TODO!
     }
 
     public override async Task<StreamState> ReceiveStream(StreamState state, ProgressViewModel progress)
@@ -120,9 +120,10 @@ public override void SelectClientObjects(List<string> args, bool deselect = fals
       // TODO!
     }
 
+    public override bool CanPreviewSend => false;
     public override void PreviewSend(StreamState state, ProgressViewModel progress)
     {
-      // TODO!
+      return;
     }
     public override async Task<string> SendStream(StreamState state, ProgressViewModel progress)
     {

diff --git a/ConnectorAutocadCivil/ConnectorAutocadCivil/UI/ConnectorBindingsAutocadCivil.cs b/ConnectorAutocadCivil/ConnectorAutocadCivil/UI/ConnectorBindingsAutocadCivil.cs
@@ -187,10 +187,10 @@ public override async Task<Dictionary<string, List<MappingValue>>> ImportFamilyC
     #endregion
 
     #region receiving 
+    public override bool CanPreviewReceive => false;
     public override async Task<StreamState> PreviewReceive(StreamState state, ProgressViewModel progress)
     {
       return null;
-      // TODO!
     }
     public override async Task<StreamState> ReceiveStream(StreamState state, ProgressViewModel progress)
     {
@@ -549,6 +549,7 @@ private bool GetOrMakeLayer(string layerName, Transaction tr, out string cleanNa
     #endregion
 
     #region sending
+    public override bool CanPreviewSend => false;
     public override async void PreviewSend(StreamState state, ProgressViewModel progress)
     {
       // TODO!

diff --git a/ConnectorCSI/ConnectorCSIShared/UI/ConnectorBindingsCSI.Recieve.cs b/ConnectorCSI/ConnectorCSIShared/UI/ConnectorBindingsCSI.Recieve.cs
@@ -16,10 +16,10 @@ namespace Speckle.ConnectorCSI.UI
 {
   public partial class ConnectorBindingsCSI : ConnectorBindings
   {
+    public override bool CanPreviewReceive => false;
     public override Task<StreamState> PreviewReceive(StreamState state, ProgressViewModel progress)
     {
       return null;
-      // TODO!
     }
 
     public override async Task<StreamState> ReceiveStream(StreamState state, ProgressViewModel progress)

diff --git a/ConnectorCSI/ConnectorCSIShared/UI/ConnectorBindingsCSI.Send.cs b/ConnectorCSI/ConnectorCSIShared/UI/ConnectorBindingsCSI.Send.cs
@@ -17,6 +17,7 @@ namespace Speckle.ConnectorCSI.UI
 {
   public partial class ConnectorBindingsCSI : ConnectorBindings
   {
+    public override bool CanPreviewSend => false;
     public override void PreviewSend(StreamState state, ProgressViewModel progress)
     {
       // TODO!

diff --git a/ConnectorMicroStation/ConnectorMicroStationOpenShared/UI/Bindings2.cs b/ConnectorMicroStation/ConnectorMicroStationOpenShared/UI/Bindings2.cs
@@ -198,6 +198,12 @@ public override async Task<Dictionary<string, List<MappingValue>>> ImportFamilyC
     #endregion
 
     #region receiving
+    public override bool CanPreviewReceive => false;
+    public override Task<StreamState> PreviewReceive(StreamState state, ProgressViewModel progress)
+    {
+      return null;
+    }
+
     public override async Task<StreamState> ReceiveStream(StreamState state, ProgressViewModel progress)
     {
       var kit = KitManager.GetDefaultKit();
@@ -444,6 +450,12 @@ private void DeleteObjects(List<ApplicationObject> previouslyReceiveObjects, Lis
     #endregion
 
     #region sending
+    public override bool CanPreviewSend => false;
+    public override void PreviewSend(StreamState state, ProgressViewModel progress)
+    {
+      return;
+    }
+
     public override async Task<string> SendStream(StreamState state, ProgressViewModel progress)
     {
       var kit = KitManager.GetDefaultKit();
@@ -850,17 +862,6 @@ public override void ResetDocument()
     {
       // TODO!
     }
-
-    public override void PreviewSend(StreamState state, ProgressViewModel progress)
-    {
-      // TODO!
-    }
-
-    public override Task<StreamState> PreviewReceive(StreamState state, ProgressViewModel progress)
-    {
-      return null;
-      // TODO!
-    }
     #endregion
   }
 }
diff --git a/ConnectorRevit/ConnectorRevit/UI/ConnectorBindingsRevit2/ConnectorBindingsRevit2.Receive.cs b/ConnectorRevit/ConnectorRevit/UI/ConnectorBindingsRevit2/ConnectorBindingsRevit2.Receive.cs
@@ -25,6 +25,8 @@ public partial class ConnectorBindingsRevit2
     public List<ApplicationObject> Preview { get; set; } = new List<ApplicationObject>();
     public Dictionary<string, Base> StoredObjects = new Dictionary<string, Base>();
 
+    public override bool CanPreviewReceive => false;
+
     public override Task<StreamState> PreviewReceive(StreamState state, ProgressViewModel progress)
     {
       return null;

diff --git a/ConnectorRevit/ConnectorRevit/UI/ConnectorBindingsRevit2/ConnectorBindingsRevit2.Send.cs b/ConnectorRevit/ConnectorRevit/UI/ConnectorBindingsRevit2/ConnectorBindingsRevit2.Send.cs
@@ -18,6 +18,7 @@ public partial class ConnectorBindingsRevit2
   {
     // used to store the Stream State settings when sending/receiving
     private List<ISetting> CurrentSettings { get; set; }
+    public override bool CanPreviewSend => true;
 
     public override void PreviewSend(StreamState state, ProgressViewModel progress)
     {