Fix: AppliedAssembly.AdjustedElevation error, and Single Point Featur…

…eline error (#3578) * Code now defaults AppliedAssembly.AdjustedElevation to double.MinValue if accessing that property throws an error. Adjusted FeatureLineToSpeckle so it only works on featurelines with more than 2 points, otherwise accessing he spline throws an error * Switched back to double.NaN * AdjustedElevation is now a double? type * Update ConverterAutocadCivil.Civil.cs --------- Co-authored-by: Claire Kuang <[email protected]>
specklesystems · Jul 24, 2024 · fe0c923 · fe0c923
1 parent 885a05b
commit fe0c923
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/...nverters/ConverterAutocadCivil/ConverterAutocadCivilShared/ConverterAutocadCivil.Civil.cs b/...nverters/ConverterAutocadCivil/ConverterAutocadCivilShared/ConverterAutocadCivil.Civil.cs
@@ -1169,7 +1169,18 @@ private CivilAppliedAssembly AppliedAssemblyToSpeckle(AppliedAssembly appliedAss
       speckleSubassemblies.Add(speckleSubassembly);
     }
 
-    CivilAppliedAssembly speckleAppliedAssembly = new(speckleSubassemblies, appliedAssembly.AdjustedElevation, ModelUnits);
+    double? adjustedElevation = null;
+    try
+    {
+      adjustedElevation = appliedAssembly.AdjustedElevation;
+    }
+    catch (ArgumentException e) when (!e.IsFatal())
+    {
+      // Do nothing. Leave the value as null.
+    }
+
+    CivilAppliedAssembly speckleAppliedAssembly = new(speckleSubassemblies, adjustedElevation, ModelUnits);
+
     return speckleAppliedAssembly;
   }
 

diff --git a/Objects/Objects/BuiltElements/Civil/CivilAppliedAssembly.cs b/Objects/Objects/BuiltElements/Civil/CivilAppliedAssembly.cs
@@ -9,7 +9,7 @@ public CivilAppliedAssembly() { }
 
   public CivilAppliedAssembly(
     List<CivilAppliedSubassembly> appliedSubassemblies,
-    double adjustedElevation,
+    double? adjustedElevation,
     string units
   )
   {
@@ -20,7 +20,7 @@ string units
 
   public List<CivilAppliedSubassembly> appliedSubassemblies { get; set; }
 
-  public double adjustedElevation { get; set; }
+  public double? adjustedElevation { get; set; }
 
   public string units { get; set; }
 }