Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revit Connector : Support Wall Opening #2723

Closed
wants to merge 1 commit into from

Conversation

chuongmep
Copy link
Contributor

@chuongmep chuongmep commented Jul 2, 2023

Description & motivation

Resolve issue : #2699
In my case study, we will allow user easier to track changed of wall opening and send email for modeler with new changed of wall follow by number of wall opening and location of them.

Changes:

To-do before merge:

Screenshots:

image

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@AlanRynne AlanRynne added this to the 2.16 milestone Jul 4, 2023
@AlanRynne AlanRynne added external revit issues related to the revit connector. labels Jul 6, 2023
@teocomi teocomi requested a review from AlanRynne July 17, 2023 17:08
@teocomi teocomi added the enhancement New feature or request label Jul 17, 2023
@AlanRynne
Copy link
Member

Hi @chuongmep!

Thanks for this! I had a chat with @teocomi and @connorivy and, although we agree the issue is legitimate, we're going to investigate a bit further the implications of this change.

We'll keep you posted, and may even ping you for some help while we scope things up (if you're up for it! 🙌🏼)

I'm changing this PR to draft for now 😉

@AlanRynne AlanRynne marked this pull request as draft July 25, 2023 16:50
@chuongmep
Copy link
Contributor Author

Hi @AlanRynne, nice to hear about that from your team. I also consider about we should link by ElementId or do with this way.

@chuongmep chuongmep closed this Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request external revit issues related to the revit connector.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants