fix(revit): instance display mesh fix once and for all🤞 #2755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clairekuang
added
revit
|
This PR was superseded by #2771 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Community-provided test file on the 2.15 announcement in the forum showed that some instances (with
.HasModifiedGeometry() = false) still have incorrect display value meshes on send.This fix will always retreive the instance geometry rather than the symbol geometry when converting definitions, and then untransform the instance geomtry - hopefully this will be the most reliable approach to accurate display meshes + transforms.
To-do before merge:
Screenshots:
Before:
After:
Validation of changes:
Tested on Revit2023 & 2024: