Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNX-9446 create enums for arc gis custom types #3429

Merged
merged 9 commits into from
May 30, 2024

Conversation

KatKatKateryna
Copy link
Contributor

@KatKatKateryna KatKatKateryna commented May 19, 2024

  • Create clear expected types for LayerGeometryType and FieldTypes
    image

  • sort received geometry by type more selectively (as fallback conversions have added possibility of mixing different converted geometry types under the same parent)

@AlanRynne AlanRynne changed the title Cnx 9446 create enums for arc gis custom types CNX-9446 create enums for arc gis custom types May 29, 2024
Copy link
Member

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so much cleaner ♥️

Whenever we support serialising Enums by their string representation we could make this even slimmer.

@AlanRynne AlanRynne merged commit 5469a12 into dui3/alpha May 30, 2024
33 checks passed
@AlanRynne AlanRynne deleted the CNX-9446-Create-Enums-for-ArcGIS-custom-types branch May 30, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants