Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Warnings picked up in net8.0 #3446

Merged
merged 1 commit into from
May 29, 2024
Merged

fix: Warnings picked up in net8.0 #3446

merged 1 commit into from
May 29, 2024

Conversation

AlanRynne
Copy link
Member

In preparation for updating to net8 as our default SDK, there were a bunch of new warnings that appeared in 8.0.300 that needed to be adressed.

These are simple fixes:

  • Use TryGetvalue in dictionaries
  • Use Length != 0 instead of Any()

@AlanRynne AlanRynne merged commit 59a9f23 into dui3/alpha May 29, 2024
10 of 31 checks passed
@AlanRynne AlanRynne deleted the dui3/alan/fix-dotnet8-warnings branch May 29, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AlanRynne