Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix revit threading #3498

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

oguzhankoral
Copy link
Member

Revit was syncing before with its current thread. This behavior changed when syncing with the Main thread became the default. I overridden it to the current thread.

- It is broken when registrations extracted out..
@JR-Morgan
Copy link
Member

JR-Morgan commented Jun 9, 2024

Should we be implementing our own Revit sync to thread, implemented using APIContext.Run? I foresee we'll need to do this for receive if not also for send.

@oguzhankoral
Copy link
Member Author

Should we be implementing our own Revit sync to thread, implemented using APIContext.Run? I foresee we'll need to do this for receive if not also for send.

Hmm, don't know yet the difference using the current thread or APIContext.Run. We can consider this when we start to implement revit receive

@oguzhankoral oguzhankoral merged commit cc70758 into dui3/alpha Jun 10, 2024
33 checks passed
@oguzhankoral oguzhankoral deleted the oguzhan/dui3/revit-sync-to-current-thread branch June 10, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants