Convert revit converters to use proxies for unit testing DUI3-149 #3501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
AlanRynne
approved these changes
Jun 14, 2024
Comment on lines
+21
to
+26
| // POC: we probably should not get here without a valid document | ||
| // so should this perpetuate or do we assume this is valid? | ||
| // relting on the context.UIApplication?.ActiveUIDocument is not right | ||
| // this should be some IActiveDocument I suspect? | ||
| new DocumentProxy( | ||
| context.UIApplication?.ActiveUIDocument?.Document |
There was a problem hiding this comment.
I think this is an initialisation thing. We may need to delay initialisation of the stack (and maybe the plugin in general) until we know the application has initialised and is no longer null.
If the UIApplication does not exist yet, we can't really do anything else from that point onwards. But I may not have the full picture about this.
There was a problem hiding this comment.
I think this is why SharedProjects are giving you so much grief? You should just let the IDE do it's thing... but I may not be right on this one. We should check...
Comment on lines
+101
to
+104
| // POC: why do we need this send selection? | ||
| // why does conversion need to know about selection in this way? | ||
| public class SendSelection | ||
| { |
There was a problem hiding this comment.
Same! Is this what is breaking your IDE experience?
adamhathcock
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://spockle.atlassian.net/browse/DUI3-149
Revit types and proxies exist in new repo: https://github.com/specklesystems/speckle-sharp-host-apis
types and proxies are consumed via Nuget (preview at the moment)
DI registration occurs with new facility to scan repo and add to Autofac as transient objects
Converter assembly only references interfaces
New test assembly made which only references interfaces
Connector assembly references APIs and Interfaces to glue together with DI
Future work:
some clean up in the connector assembly
Need to be careful to ensure no breaking. Probably around some casting?