-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
D ui3 123 receiving non native attributes revit params gh attributes etc #3526
Merged
KatKatKateryna
merged 25 commits into
dui3/alpha
from
DUI3-123-Receiving-Non-Native-Attributes-Revit-Params-GH-Attributes-etc
Jun 21, 2024
Merged
D ui3 123 receiving non native attributes revit params gh attributes etc #3526
KatKatKateryna
merged 25 commits into
dui3/alpha
from
DUI3-123-Receiving-Non-Native-Attributes-Revit-Params-GH-Attributes-etc
Jun 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… prepare to get correct FieldType
…es-Revit-Params-GH-Attributes-etc
adamhathcock
approved these changes
Jun 20, 2024
* option for dealing with nullable types * fmt
@adamhathcock I tested with the new function, and "default" value doesn't work very well (e.g. it assigns a random date like "{01/01/0001 00:00:00}" ). So I changed it to null and removed a redundant null check from the method calling this one. |
KatKatKateryna
deleted the
DUI3-123-Receiving-Non-Native-Attributes-Revit-Params-GH-Attributes-etc
branch
June 21, 2024 10:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPD: receiving of non-native properties has been turned into a placeholder until we find better strategy for sending props from host apps.
Purpose is to preserve objects properties when placing them into GIS layers(tables).
Current approach is to iterate through all objects that will be placed under the same layer and collect their property names and their Type (e.g. string, int) while defaulting to string if nothing better fits).
The opinionated choice of non-native properties to receive is:
P.S. atm the following exception is being generated inconsistently, needs better understanding. Thrown during "Conversion" step, so likely not a problem with the current PR: