Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D ui3 123 receiving non native attributes revit params gh attributes etc #3526

Conversation

KatKatKateryna
Copy link
Contributor

@KatKatKateryna KatKatKateryna commented Jun 19, 2024

UPD: receiving of non-native properties has been turned into a placeholder until we find better strategy for sending props from host apps.

Purpose is to preserve objects properties when placing them into GIS layers(tables).
Current approach is to iterate through all objects that will be placed under the same layer and collect their property names and their Type (e.g. string, int) while defaulting to string if nothing better fits).
The opinionated choice of non-native properties to receive is:

  • all properties that are not Base: Dynamic for "Objects.Geometry" and Typed for everything else
  • Base properties if its Revit "properties" or Rhino "userStrings"

P.S. atm the following exception is being generated inconsistently, needs better understanding. Thrown during "Conversion" step, so likely not a problem with the current PR:
image

image

@KatKatKateryna KatKatKateryna marked this pull request as ready for review June 19, 2024 18:12
@KatKatKateryna
Copy link
Contributor Author

@adamhathcock I tested with the new function, and "default" value doesn't work very well (e.g. it assigns a random date like "{01/01/0001 00:00:00}" ). So I changed it to null and removed a redundant null check from the method calling this one.

@KatKatKateryna KatKatKateryna merged commit 2930bcf into dui3/alpha Jun 21, 2024
33 checks passed
@KatKatKateryna KatKatKateryna deleted the DUI3-123-Receiving-Non-Native-Attributes-Revit-Params-GH-Attributes-etc branch June 21, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants