Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DUI3-448 both model card types need 2 clicks to actually cancel 1 to stop operation and 1 to refresh progress bar #3538

Conversation

oguzhankoral
Copy link
Member

@oguzhankoral oguzhankoral commented Jun 27, 2024

It was random probably with some race condition, connectors send sometimes last progress update after cancel and it causes the invalid UI state that seems like progress stuck in UI.

  • Removed unnecassary dup code in bindings, even function names was wrong.. i.e. OnSendProgressUpdate in Receive binding.
  • Added cancellation token cancelled? check to prevent progress update for any reason. I believe this is the safest fix for now.

KatKatKateryna and others added 2 commits June 28, 2024 13:19
…licks-to-actually-cancel-1-to-stop-operation-and-1-to-refresh-progress-bar
@oguzhankoral oguzhankoral merged commit cbe19c7 into dui3/alpha Jun 28, 2024
33 checks passed
@oguzhankoral oguzhankoral deleted the DUI3-448-Both-ModelCard-types-need-2-clicks-to-actually-cancel-1-to-stop-operation-and-1-to-refresh-progress-bar branch June 28, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants