-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DUI3-71 receive bindings and receive geometry #3542
DUI3-71 receive bindings and receive geometry #3542
Conversation
…-create-bindings-and-other-receive-boiler-plate-for-Revit
…-create-bindings-and-other-receive-boiler-plate-for-Revit
…-create-bindings-and-other-receive-boiler-plate-for-Revit
builder.AddScoped<ReceiveOperation>(); | ||
builder.AddScoped<IHostObjectBuilder, RevitHostObjectBuilder>(); | ||
builder.AddScoped<TransactionManager>(); | ||
builder.AddSingleton(DefaultTraversal.CreateTraversalFunc()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep perfect. This new and improved DefaultTraversal
is exactly what we should be using (injecting as you have here) from now on.
Tldr, this one should behave functionally equivalent to the old one, while no longer being dependent on the old CanConvertFunction
.
The PR is definitely wrong somehow as it has a lot of commits from me in it but should be covered with a merge. Let me know if you need help redoing/rebasing the branch? |
closing this pr in favor of a new one that doesn't have a bunch of Adam's commits in it #3542 |
Description & motivation
Changes:
Connectors / Revit
Converter / Revit
Converter / Revit / ToHost
Converter / Revit / ToSpeckle
Converter / Rhino
To-do before merge:
Screenshots:
Validation of changes:
receiving works for model lines of various types
Checklist:
References