-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaning classes #360
Open
KatKatKateryna
wants to merge
16
commits into
v3-dev
Choose a base branch
from
cleaning_classes
base: v3-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Cleaning classes #360
Changes from 15 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
21249f0
remove gis classes, rename collections
KatKatKateryna 3362d09
remove gis classes
KatKatKateryna eafa6f2
add ISpeckleObject model
KatKatKateryna edfb515
add proxies
KatKatKateryna 8e0d47b
add instances
KatKatKateryna 3ea301f
remove interface
KatKatKateryna 0a918ae
formatting
KatKatKateryna 6c154b0
typo
KatKatKateryna 9358496
remove structural classes
KatKatKateryna 46b56b9
remove more objects
KatKatKateryna f33bbbd
add tests
KatKatKateryna 7d25b6b
isort
KatKatKateryna 4ff2931
unused var
KatKatKateryna 58b04c2
typo
KatKatKateryna 71ca531
fix tests
KatKatKateryna 0fcc305
RenderMaterialProxy
KatKatKateryna File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
from specklepy.objects.base import Base | ||
|
||
|
||
class InstanceProxy( | ||
Base, | ||
speckle_type="Speckle.Core.Models.Instances.InstanceProxy", | ||
): | ||
""" | ||
A proxy class for an instance (e.g, a rhino block, or an autocad block reference). | ||
""" | ||
|
||
definitionId: str | ||
transform: list[float] | ||
units: str | ||
maxDepth: int | ||
|
||
|
||
class InstanceDefinitionProxy( | ||
Base, | ||
speckle_type="Speckle.Core.Models.Instances.InstanceDefinitionProxy", | ||
): | ||
""" | ||
A proxy class for an instance definition. | ||
""" | ||
|
||
objects: list[str] | ||
maxDepth: int | ||
name: str |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
from specklepy.objects.base import Base | ||
|
||
|
||
class ColorProxy( | ||
Base, | ||
speckle_type="Speckle.Core.Models.Proxies.ColorProxy", | ||
): | ||
""" | ||
Represents a color that is found on objects and collections in a root collection. | ||
""" | ||
|
||
objects: list[str] | ||
value: int | ||
name: str | None # nullable but required | ||
|
||
|
||
class GroupProxy( | ||
Base, | ||
speckle_type="Speckle.Core.Models.Proxies.GroupProxy", | ||
): | ||
""" | ||
Grouped objects with a meaningful way for host application so use this proxy if you want to group object references for any purpose. | ||
i.e. in rhino -> creating group make objects selectable/moveable/editable together. | ||
""" | ||
|
||
objects: list[str] | ||
name: str |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see some proxy classes were added, but looks like
renderMaterialProxy
is missingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm I see, shall we move it in C# accordingly as well? Right now it's not in Proxies classes list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently it relies on
RenderMaterial
which is inObjects
, notCore
. Both would have to be moved toCore
if soThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, noticed it, added it to the same place as in C#