Removes all FE1 client functions #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortenengen
reviewed
Feb 17, 2025
| ) | ||
| version = client.version.create(input) | ||
| ``` | ||
| """ | ||
|
|
There was a problem hiding this comment.
@JR-Morgan, this is really minor, but ServerTransport still has stream_id as an attribute and as arg in __init__. Should we consider renaming this to project_id to align it with the rest of the library?
There was a problem hiding this comment.
Good point. I think there's still a couple places left in the SDK that we should update to the new naming.
I'll do this in a separate PR
|
|
dogukankaratas
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #384