fix(permissions): filters nulls out in places

filters any nulls in canRead and canWrite arrays

part fixes #118

app/api/middleware/PermissionCheck.js

@@ -41,8 +41,8 @@ module.exports = ( user, operation, resource, mod ) => {
     }
 
     // let's get basic
-    let canRead = resource.canRead.map( x => x.toString( ) )
-    let canWrite = resource.canWrite.map( x => x.toString( ) )
+    let canRead = resource.canRead.filter( x => !!x ).map( x => x.toString( ) )
+    let canWrite = resource.canWrite.filter( x => !!x ).map( x => x.toString( ) )
 
     switch ( operation ) {
       case 'write':

app/api/projects/ProjectPut.js

@@ -11,7 +11,11 @@ module.exports = ( req, res ) => {
 
   Project.findOne( { _id: req.params.projectId } )
     .then( resource => PermissionCheck( req.user, 'write', resource ) )
-    .then( resource => resource.set( req.body ).save( ) )
+    .then( resource => {
+      resource.canRead = resource.canRead.filter( x => !!x )
+      resource.canWrite = resource.canWrite.filter( x => !!x )
+      return resource.set( req.body ).save( )
+    } )
     .then( ( ) => {
       res.send( { success: true, message: `Patched ${Object.keys( req.body )} for ${req.params.projectId}.` } )
     } )

app/api/streams/StreamPut.js

@@ -30,6 +30,10 @@ module.exports = ( req, res ) => {
     .then( result => {
       stream.set( req.body )
       if ( objsToSave.length > 0 ) stream.objects = result.map( obj => obj._id )
+
+      stream.canRead = stream.canRead.filter( x => !!x )
+      stream.canWrite = stream.canWrite.filter( x => !!x )
+
       return stream.save( )
     } )
     .then( ( ) => {