This repository has been archived by the owner on Aug 28, 2021. It is now read-only.
capitalisation of client types #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe not an issue per se, but just wanted to point this out...
I noticed that the
client.typeinstore.jsis specificied either as asenderorreceiver(not capitalized). However, the currentSpeckleRhinoapp produces clients which are specified asSenderorReceiver(capitalized). Not sure what is right or wrong, but I think it should be consistent and the exact same everywhere?Affected project:
For example, this affects SpeckleViz, as it checks for
SenderandReceivertypes and notsenderorreceivertypes... SpeckleExcel, on the other hand, built withSpeckleUiApp, producessenderorreceivertypes. This results in isolated Excel islands which are disconnected on the graph, see below ¯_(ツ)_/¯I'm aware that I'm very nit-picky here, I could also convert all the types in lowercase and check them against it in SpeckleViz, but I think beyond the latter, it's good to remain consistent through all repos...