-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rethink Type
and NamedType
+ rewrite specta_typescript
#308
Draft
oscartbeaumont
wants to merge
32
commits into
main
Choose a base branch
from
changes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscartbeaumont
changed the title
Rethink
Rethink Jan 20, 2025
Type
and NamedType
Type
and NamedType
+ rewrite specta_typescript
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an exploration into rethinking the core Specta interface with the goal of supporting
specta-jsonschema
convertingschemars::Schema -> specta::DataType
.TODO:
variants.dedup();
field_flattened
jsdoc
andlegacy
modules from Typescriptdetect_duplicate_type_names
hooked back upDataTypeFrom
Future:
NamedDataType
whats the plan? RenameNamedType
trait???to_named
??NamedDataTypeExt
ontoNamedDataType
?TypeCollection::flatten_stack
is it still needed?datatype::inline
module. It's not a Specta feature?DataType::Generic
be a specialReference
instead?docs
anddeprecated
fromNamedDataType
toStructType
/EnumType
. Would help Mattrax & struct fields also hold docs so... - Would prevent documenting/deprecating a primtive type though so idk.static_types.rs
intospecta_typescript
DataType::Any
,DataType::Unknown
, etc.