fix(bash): nounset unbound file filter variable on empty extension #2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Happens at least if a flag is marked as filename, with "" given as extensions.
scop
added a commit
to scop/goreleaser
that referenced
this pull request
Feb 1, 2025
Passing the empty string as an extension is a functional no-op, but causes actual problems: spf13/cobra#2228 Remove marking the flag as taking filename altogether, as there's no need to do that; cobra comments doing so as a mistake: https://github.com/spf13/cobra/blob/41b26ec8bb59dfba580f722201bf371c4f5703dd/completions.go#L387-L390 Leave MarkFlagFilename in comments so it's clear it's not inadvertently left out.
caarlos0
pushed a commit
to goreleaser/goreleaser
that referenced
this pull request
Feb 3, 2025
Passing the empty string as an extension is a functional no-op, but causes actual problems: spf13/cobra#2228 Remove marking the flag as taking filename altogether, as there's no need to do that; cobra comments doing so as a mistake: https://github.com/spf13/cobra/blob/41b26ec8bb59dfba580f722201bf371c4f5703dd/completions.go#L387-L390 Leave MarkFlagFilename in comments so it's clear it's not inadvertently left out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happens at least if a flag is marked as filename, with "" given as extensions.
Foe example, current goreleaser (2.6.1) gives this
https://github.com/goreleaser/goreleaser/blob/fb003f17c26e9388be64eb3930fe1b337325cf8d/cmd/build.go#L100
Arguably a bug to set an empty string there. Not sure if this should be filtered before it enters bash code, but at least this is a "cheap" workaround.