Skip to content
This repository has been archived by the owner on Mar 10, 2021. It is now read-only.

Nodejs travis check #19

Closed
wants to merge 10 commits into from
Closed

Nodejs travis check #19

wants to merge 10 commits into from

Conversation

emmenko
Copy link
Collaborator

@emmenko emmenko commented Nov 20, 2014

No description provided.

@schleichardt
Copy link
Contributor

I made three pull requests where the projects root directory was saved into projects_dir and I only ran one config script for all projects. I think this should be uniform.

https://github.com/sphereio/sphere-hello-api/pull/18/files#diff-354f30a63fb0907d4ad57269548329e3R3

@schleichardt
Copy link
Contributor

I think we should only use on project, I sent you the credentials.

@butenkor
Copy link

Why not put each language specific example into its own repository? This repo could just link to other repos. This would make build process simpler and easier to understand for visitors looking for particular examples.

@OlegIlyenko
Copy link
Contributor

Looks list a complete demo shop now, instead of hello world application :)

@emmenko
Copy link
Collaborator Author

emmenko commented Nov 20, 2014

@OlegIlyenko I wanted to provide a practical example and use-case where people can start with instead of the classical useless 3 lines example. I could have just use a single file like this

// hello.js
var config = {
  project_key: 'PROJECT_KEY', 
  client_id: 'CLIENT_ID',
  client_secret: 'CLIENT_SECRET'
}
var client = new require('sphere-node-sdk').SphereClient({config: config})
client.products.fetch().then(function(result){
  console.log(result)
})

But you can't practically start anything with this. I find it useful to have a basic starting point.

@emmenko
Copy link
Collaborator Author

emmenko commented Nov 20, 2014

@butenkor makes sense yes. I opened a ticket #20

@OlegIlyenko
Copy link
Contributor

@emmenko i find the example you implemented very good, so we definitely need to keep it. But I think that we also need extra one small 3 line example - just a trivial hello world (at least i though that it's the purpose of this repo to contain such examples)

@schleichardt
Copy link
Contributor

I agree with @OlegIlyenko .

@emmenko
Copy link
Collaborator Author

emmenko commented Nov 20, 2014

I will provide then also a simple example then 👍

@OlegIlyenko
Copy link
Contributor

cool, thanks a lot!

@emmenko
Copy link
Collaborator Author

emmenko commented Nov 20, 2014

@emmenko emmenko closed this Nov 20, 2014
@emmenko emmenko deleted the nodejs-travis-check branch November 20, 2014 14:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants