Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(stage): add test to cover scenario when clouddriver returns a failure #4847

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

test(stage): add test to cover scenario when clouddriver returns a failure #4847

wants to merge 5 commits into from

Conversation

edgarulg
Copy link
Contributor

Adding a missing test for WaitForManifestStableTask. This test validates that the task's context is reset if Clouddriver returns a SpinnakerServerException while waiting for the manifests to stabilize. This means that the stable manifests previously validated by Orca are removed from the context, and Orca restarts the validation process for all deployed manifests.

@edgarulg
Copy link
Contributor Author

@dbyron-sf I removed the AssertionsForClassTypes import and commit your suggested changes. Thanks for the feedback.

@edgarulg
Copy link
Contributor Author

edgarulg commented Mar 6, 2025

@dbyron-sf I removed the star imports you asked me to remove. FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbyron-sf dbyron-sf dbyron-sf left review comments

@jasonmcintosh jasonmcintosh Awaiting requested review from jasonmcintosh

@christosarvanitis christosarvanitis Awaiting requested review from christosarvanitis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edgarulg @dbyron-sf