fix: Add NOT NULL to many fields #143 (Ademola111) #1268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, can you explain the reasoning behind this change? |
|
Reading from the issue question I got to know that you wasn’t the database
to be secured by adding nullable=True to all tables in the database so I
pick it up to contribute as part of my open source.
Thank you.
…On Thu, 23 Nov 2023 at 23:10, zorun ***@***.***> wrote:
Hi, can you explain the reasoning behind this change?
—
Reply to this email directly, view it on GitHub
<#1268 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APB5FCF45Y5NWR7GPYIIHQ3YF7CVRAVCNFSM6AAAAAA7R3QE2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRUHE3DAMZSGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Thanks for the work on this. I'm doing some winter cleanup on the repo, and closing this as it had no activity since more than a year. Feel free to reopen if you feel like it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the NOT NULL fields and i would like to have it reviewed. more so i will be glad to join the community to contribute more. Warm regards.