Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spm_BIDS.m DWI allows 'dir' #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

spm_BIDS.m DWI allows 'dir' #7

wants to merge 1 commit into from

Conversation

CPernet
Copy link

@CPernet CPernet commented Nov 9, 2023

in the case of separate additional acquisitions AP/PA it currently fails, e.g.

f =
{'/sub-048/dwi/sub-048_dir-AP_dwi.nii'}
{'/sub-048/dwi/sub-048_dir-PA_dwi.nii'}
{'/sub-048/dwi/sub-048_dwi.nii'       }

simply adding 'dir' does the job

@gllmflndn
Copy link

Hello @CPernet 👋

There is a similar PR on the development version of SPM: spm/spm#9

Would it be OK to merge it there?

@CPernet
Copy link
Author

CPernet commented Nov 10, 2023

looking at the whole PR, all those are indeed BIDS keys you could just merge

@CPernet
Copy link
Author

CPernet commented Jun 21, 2024

Anyone took over the repo?

@pzeidman
Copy link

Thank you Cyril for following up on this PR! Unfortunately we've had a hold-on up on being able to accept PRs, but I'll take a look at this and see if we can get it patched ASAP - I'll be in touch next week.

Best
Peter @ SPM

@CPernet
Copy link
Author

CPernet commented Jun 22, 2024

Should not we try to crowd source? Like some other project so it less depending on UCL people - I'm in Seoul right now if anyone want to have that conversation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants